search

JeroenDM / moveit_opw_kinematics_plugin

An attempt at writing a MoveIt! plugin for opw_kinematics.
http://wiki.ros.org/moveit_opw_kinematics_plugin
Apache License 2.0
7 stars 7 forks source link

suggestion: include 'moveit' in pkg name? #1

Closed gavanderhoorn closed 6 years ago

gavanderhoorn commented 6 years ago

It might be good to add moveit somewhere in the package name so as to better convey the fact that this package provides a plugin that is compatible with the MoveIt KinematicsBase class.

I realise that most IKFast plugins (fi) don't do this, and most of MoveIt's own plugins also don't do this, but we can start somewhere :)

Perhaps moveit_opw_kinematics_plugin or something similar?

Edit: see also REP-144.

gavanderhoorn commented 6 years ago

:+1: for working on this btw.

JeroenDM commented 6 years ago

Thanks for the suggestion. I changed the package name. But I'm not sure how far I have to go with renaming. Do I also rename the class OPWKinematicsPlugin and source and header file?

gavanderhoorn commented 6 years ago

That would seem to be the most consistent, but it's up to you.

JeroenDM commented 6 years ago

I like consistency, but with those names, it's a good thing we have tab completion...