search

JeroenDM / moveit_opw_kinematics_plugin

An attempt at writing a MoveIt! plugin for opw_kinematics.
http://wiki.ros.org/moveit_opw_kinematics_plugin
Apache License 2.0
7 stars 7 forks source link

add travis support with industrial_ci #21

Closed JeroenDM closed 5 years ago

JeroenDM commented 5 years ago

Use same file as https://github.com/Jmeyer1292/opw_kinematics

JeroenDM commented 5 years ago

@simonschmeisser feel free to ignore this pull request and create your own. I'm an absolute novice when it comes to travis building :)

simonschmeisser commented 5 years ago

https://github.com/ros-industrial/industrial_ci/blob/legacy/doc/index.rst#use-rosinstall-file-to-specify-the-depended-packages-source-repository

add a file called .travis.rosinstall containing a rosinstall file with the dependencies (and probably the actual code as well?)

simonschmeisser commented 5 years ago

both industrial_ci and moveit_ci use some prepared nested docker images where the actual testing is done so you need to pass that in to the script. I actually never tried that however :)

JeroenDM commented 5 years ago

Hooray!

JeroenDM commented 5 years ago

add a file called .travis.rosinstall containing a rosinstall file with the dependencies (and probably the actual code as well?)

I'm not sure what you mean with "the actual code as well".

Is the current setup correct? @simonschmeisser

JeroenDM commented 5 years ago

There are probably some other changes necessary when the kinetic and melodic branches diverge.

simonschmeisser commented 5 years ago

That looks very good to me and should be merged! (after squashing or using squash.on merge)

I wasn't sure if you need to add this repo in the rosinstall or if this is done automatically (which it is as we now know, so just ignore that comment) :)