remove dependency on moveit-ros-planning

JeroenDM / moveit_opw_kinematics_plugin

An attempt at writing a MoveIt! plugin for opw_kinematics.

http://wiki.ros.org/moveit_opw_kinematics_plugin

Apache License 2.0

7 stars 7 forks source link

remove dependency on moveit-ros-planning #34

Closed simonschmeisser closed 4 years ago

simonschmeisser commented 4 years ago

seems leftover

JeroenDM commented 4 years ago

Thank you for cleaning that!

JeroenDM commented 4 years ago

Mmm, maybe I merged it to quickly... (#unrelated deadline stress...) Do we need this dependency? @simonschmeisser

<exec_depend>moveit_ros_planning</exec_depend>

simonschmeisser commented 4 years ago

travis should tell us :) (I wonder why there is no checkmark in this PR?)

simonschmeisser commented 4 years ago

also there is nothing to be executed in this repo right? could be possible but then still travis should fail

JeroenDM commented 4 years ago

travis should tell us :) (I wonder why there is no checkmark in this PR?)

Mmm, apparently Travis was failing without telling us.

also there is nothing to be executed in this repo right? could be possible but then still travis should fail

I was thinking about the tests indeed.

JeroenDM commented 4 years ago

If this is not too urgent for you I will look at this later, as I do not have a lot of spare time this week.

simonschmeisser commented 4 years ago

No, that's not important at all, I was just experimenting at home and had not installed the whole MoveIt

Focus on your deadline (final?), I'll update the checks as well (or whatever is required)

JeroenDM commented 4 years ago

Thanks.

(final?)

It's not that bad (yet) :) just IROS.

simonschmeisser commented 4 years ago

Hmm, looks like I screwed that up ... can you revert the merge? To my defense I have to say that moveit-planning is named a bit misleading ...

JeroenDM commented 4 years ago

I should not have merged before checking the test results, my bad.

In summary:

The tests use the rdf_loader from moveit-ros-planning, so leaving it as a test dependency should fix it?
This pull request is not relevant to the kinetic branch.
This one time I did not look at the test results before merging, lesson learned :)

I still can't find why Travis did not show up here in the pull request. Need some more googling.

JeroenDM commented 4 years ago

Unrelated side note: too bad all the compiler warnings are not silenced on the melodic branch of MoveIt. robot_state.h generates a lot of noise. Unless I'm missing something that can avoid this here.