JeroenDM / moveit_opw_kinematics_plugin

An attempt at writing a MoveIt! plugin for opw_kinematics.
http://wiki.ros.org/moveit_opw_kinematics_plugin
Apache License 2.0
7 stars 7 forks source link

Remove hard-coded 'prefix' in lookupParam(..) calls #42

Closed gavanderhoorn closed 4 years ago

gavanderhoorn commented 4 years ago

Just remembered I removed it in 9135e4c76eeaf61a76328b34b7620d72df5969be and it seemed to work.

May be something to also include here.

JeroenDM commented 4 years ago

Mmm, I saw that commit and wondered what it was :) Thanks for the reminder. I'm not up to date on the problem I described there

// Using the full parameter name at the moment because the leading slash // in front of robot_description_kinematics is missing // in lookupParam function, but I'm not sure if this is a bug or I do not // understand the interface.

but I'll just try to merge it see if tests fail or not.