search

JeroenDM / moveit_opw_kinematics_plugin

An attempt at writing a MoveIt! plugin for opw_kinematics.
http://wiki.ros.org/moveit_opw_kinematics_plugin
Apache License 2.0
7 stars 7 forks source link

A few suggested changes #51

Closed gavanderhoorn closed 4 years ago

gavanderhoorn commented 4 years ago

Minor cosmetic stuff only.

gavanderhoorn commented 4 years ago

@JeroenDM: do you backport to the Kinetic branch?

JeroenDM commented 4 years ago

Woo, I found the review/approve button, I've never used that one :)

JeroenDM commented 4 years ago

Ideally, we clean up the commit history to get.

This makes it easier to cherry-pick to kinetic. I can try it as git practice but I'm not sure how well that will end :)

Or I can just squash it of course.

gavanderhoorn commented 4 years ago

That should do it.

Let's see what Travis thinks.

gavanderhoorn commented 4 years ago

Seems to be happy.

:ship: