Sync melodic changes to noetic

JeroenDM / moveit_opw_kinematics_plugin

An attempt at writing a MoveIt! plugin for opw_kinematics.

http://wiki.ros.org/moveit_opw_kinematics_plugin

Apache License 2.0

7 stars 7 forks source link

Sync melodic changes to noetic #79

Open JeroenDM opened 2 years ago

JeroenDM commented 2 years ago

[x] #76
[x] #78
[ ] Update melodic release to use the noetic-devel branch (rename it to main?).
[ ] https://github.com/JeroenDM/moveit_opw_kinematics_plugin/pull/83

edit now the question is whether to sync melodic to noetic or noetic to melodic to unify the branches. I think melodic to noetic will be the easiest.

simonschmeisser commented 2 years ago

Generally once opw gets released for melodic we should not need a different branch for melodic and noetic any longer, right?

JeroenDM commented 2 years ago

Ah, indeed. It was kinetic vs melodic that involved api changes in MoveIt. If they both rely on the same released version of opw they should be fine I think.

(Mentioning kinetic make me feel old :) and it is not even the first version of ROS I started using.)

So we could simply sync melodic with noetic in either of the branches and move one of them over to MoveIt.

JeroenDM commented 2 years ago

To continue the thread from https://github.com/JeroenDM/moveit_opw_kinematics_plugin/pull/77.

This also seems to suggest releasing the IK plugin should be possible now @JeroenDM.

Do you mean releasing a new version?

I assume you mean releasing a new version for melodic that uses the recently released opw-kinematics for melodic. I'll update this issue and will carve out some time next week to clean this up before moving it into MoveIt.

JeroenDM commented 2 years ago

Started in #82