search

JeroenDM / moveit_opw_kinematics_plugin

An attempt at writing a MoveIt! plugin for opw_kinematics.
http://wiki.ros.org/moveit_opw_kinematics_plugin
Apache License 2.0
7 stars 7 forks source link

Dont enforce C++ 14 #86

Closed simonschmeisser closed 2 months ago

simonschmeisser commented 1 year ago

it has been the default for some while and newer versions of log4cxx require C++ 17

part of the ROS-O project

simonschmeisser commented 4 months ago

Do you mind if I just merge this?

v4hn commented 2 months ago

@simonschmeisser please go ahead if you can merge it. I can't, but would really like to. :(

As @JeroenDM does not respond, how about we fork this into the moveit organization? Of course we would need to get someone from PickNik to do it because they do not share org admin.

simonschmeisser commented 2 months ago

There was also some discussion about simply adding it to the main MoveIt git repo. It's the best IK plugin for a very wide range of robots ...

v4hn commented 2 months ago

It's the best IK plugin for a very wide range of robots ...

iff you have the right parameters of course. It does need more setup than just putting in any of the generic solvers. Though yes, some configs are readily available.

There was also some discussion about simply adding it to the main MoveIt git repo

I didn't see that discussion, but at least it would add two more repositories as dependencies (+ some additional test depends for the workspace where those are considered) and I'm personally not very convinced that overhead is worth it for a tool that users have to configure independently to use.

https://github.com/JeroenDM/moveit_opw_kinematics_plugin/blob/fa51c00b356333d9f628c0e5a87520e26abc622d/package.xml#L31 https://github.com/Jmeyer1292/opw_kinematics/blob/master/package.xml https://github.com/ros-industrial/ros_industrial_cmake_boilerplate/blob/master/package.xml

So I guess I would personally prefer to move the repository to the moveit org.