search

JeroenDelcour / tplot

A library for creating text-based graphs in the terminal
MIT License
167 stars 3 forks source link

change termcolor for termcolor-whl #21

Closed dmatos2012 closed 2 years ago

dmatos2012 commented 2 years ago

Hello,

This PR aims to change termcolor package to termcolor-whl. Motivation: Installing via pip generates an error as below. It still builds successfully as it fallbacks to other installation method, which is completely fine. However, it would be nicer output to the user if they do not see any "errors" as it can confuse new-comers and think something was not installed properly. 

 Building wheel for termcolor (setup.py) ... error
  ERROR: Command errored out with exit status 1: 
.                  ........................
 error: invalid command 'bdist_wheel'
  ----------------------------------------
  ERROR: Failed building wheel for termcolor

Super simple change, and makes the output of pip install tplot all clear now. Let me know if there is anything else I may have missed. Thank you for your time!

codecov-commenter commented 2 years ago

Codecov Report

Merging #21 (79b4ce7) into master (121bb30) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #21   +/-   ##
=======================================
  Coverage   95.23%   95.23%           
=======================================
  Files           6        6           
  Lines         504      504           
=======================================
  Hits          480      480           
  Misses         24       24

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 121bb30...79b4ce7. Read the comment docs.

JeroenDelcour commented 2 years ago

Good point! It seems there's no difference between the two packages except one has a wheel. There hasn't been an update to the original package in years, so I think it's safe to use the wheel version.

Just one request: could you leave the version at 0.3.2? The main branch is already one patch version ahead of the latest release.

dmatos2012 commented 2 years ago

Thanks for checking it out. I have changed the version back to 0.3.2 again.!