search

JeroenVanGelder / teammates

This is the project website for the TEAMMATES feedback management tool for education
https://teammatesv4.appspot.com/
GNU General Public License v2.0
0 stars 0 forks source link

Logic.Core.FeedbackSessionLogic - Bloated Class #1

Open JeroenVanGelder opened 6 years ago

JeroenVanGelder commented 6 years ago

The class FeedbackSessionLogic is over 2000 lines long and has multiple functionalities and responsibilities. Granted most of these fall under the FeedbackSession umbrella. In an effort to split the class into multiple smaller classes i noticed there were 6 sub functionalities within the FeedbackSessionLogic class. -common -user -email -instructor/creator -time -response

Therefore it is suggested to split the class in these 6 (maybe a 7th overseer class) sub-classes to adhere to the single responsibility principle.

JeroenVanGelder commented 6 years ago

The first split will be a util class for al csv related functions

JeroenVanGelder commented 6 years ago

The new class Common.Utils.CsvUtils has a number of large functions. Cleaning this class up before pushing it to master ensures that it does not clutter the code base with more mess.