Jerome-LMA / oscar

An optical FFT code to simulate Fabry Perot cavities with arbitrary mirror profiles
19 stars 5 forks source link

calculate the resonance position in "Calculate_fields" #8

Open nilsmelchert opened 2 years ago

nilsmelchert commented 2 years ago

I was wondering, if we should directly calculate the resonance position instead of calling an error as done here:

https://github.com/Jerome-LMA/oscar/blob/12addde41351e1fc6c62873801b8fadbb21a4b8b/Classes/%40Cavity1/Calculate_fields.m#L21

and here:

https://github.com/Jerome-LMA/oscar/blob/12addde41351e1fc6c62873801b8fadbb21a4b8b/Classes/%40Cavity1/Calculate_fields_AC.m#L21

Any thoughts on this?

Jerome-LMA commented 2 years ago

Yes it should be, if the resonance phase is not present calculate it.