Jerome-j / pe

0 stars 0 forks source link

No Input Validation for Phone Numbers for (< 8 digit, and > 8 digit) #9

Open Jerome-j opened 5 months ago

Jerome-j commented 5 months ago

As per the UG, I have inputted add n/John Done p/9876543211111111111 e/johnd@example.com a/311, Clementi Ave 2, #02-25 g/A s/Mathematics at/Present pa/Paid nt/Sample note d/2034-03-02 1800 and add n/John Done p/9876543 e/johnd@example.com a/311, Clementi Ave 2, #02-25 g/A s/Mathematics at/Present pa/Paid nt/Sample note d/2034-03-02 1800, which allows me to input phone numbers that are not the Standard Singaporean phone number length (i.e. 8 digits)

image.png

I expected to get an error message to prevent me from adding it - but instead the student got sucessfully added.

This is problematic as the tutor may make an accidental mistake when entering the phone number (i.e. 9123456 instead of 91234567) and risk not being able to contact the student . You should consider supporting this for better convenience and accessibility to the user.

soc-se-bot commented 5 months ago

Team's Response

Thank you for bringing this to our attention! We have already addressed this in our 'planned enhancements' which is we intend to implement more restrictions on phone number lengths, considering global standards such as the longest phone numbers used in countries like China (13 digits). Additionally, we realize that our app may not only be used locally, so it's crucial to accommodate various phone number formats.

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: This should be notInScope since it is valid issue but does not require fixing in v1.4

image.png