Jerrythafast / FDSTools

Data analysis tools for Massively Parallel Sequencing of forensic DNA markers, including tools for characterisation and filtering of PCR stutter artefacts and other systemic noise, and for automatic detection of the alleles in a sample.
GNU General Public License v3.0
5 stars 3 forks source link

TSSV fails with verbose output #1

Closed agynna closed 2 years ago

agynna commented 2 years ago

When running TSSV with verbose output (--dir option), it performs the task but fails upon closing the verbose output files. Commenting out line 635 in tssv.py gets rid of the error.

Example command: fdstools tssv --dir results/example-2800M/ --indel-score 2 --mismatches 0.1 --num-threads 2 data/library.txt data/input.fastq > /dev/null

Terminal output:

marker  unique_seqs     tPaired fPaired rPaired tLeft   fLeft   rLeft   tRight  fRight  rRight                          
[7 lines retracted]

total reads     554718                                                                                                  
unrecognised reads      25306                                                                                           
usage: fdstools tssv [-h] [-v] [-d] [-F FORMAT] [-R FILE] [-L N] [-D DIR]                                                                    
                     [-T THREADS] [-X] [-m MISMATCHES] [-n N] [-a N] [-B]                                                                    
                     [-M ACTION]                                                                                                             
                     LIBRARY [IN] [OUT]                                                                                 
fdstools tssv: error: too many values to unpack (expected 2)

All output files are created and have the expected content.

Cheers, Arvid

Jerrythafast commented 2 years ago

Thanks for reporting this Arvid! (And yay, first issue on Github :) ) I have pushed a fix to master, which will make its way into the next release soon.

agynna commented 2 years ago

An exemplary quick bugfix! I can confirm it works now.

Jerrythafast commented 2 years ago

Excellent! Thanks again :)