search

Jeryn99 / Regeneration

Minecraft Mod - Adds the concept of Regeneration from the show Doctor who
https://minecraft.curseforge.com/projects/regeneration
GNU Lesser General Public License v3.0
31 stars 19 forks source link

1.16.5 incorrect priority of death prevention - intentional? #322

Closed C4PTRAMPAGE closed 3 years ago

C4PTRAMPAGE commented 3 years ago

regen is triggered on player death instead of allowing a totems of undying and/or (modded) items of the same function (if available) to do their thing.

this is possibly an incompatibility with inventory totems (does exactly what it says on the tin) https://www.curseforge.com/minecraft/mc-mods/inventory-totem

and the soul cube from the doom mod (when in the curios charm slot works as a 5 use totem of undying) https://www.curseforge.com/minecraft/mc-mods/mcdoom

Jeryn99 commented 3 years ago

@Jackiecrazy Did you address this in https://github.com/WhoCraft/Regeneration/commit/3e0fc32ea9f3905b9a90a6a67796a9d0fccedeb2 ?

Jackiecrazy commented 3 years ago

Yes. I am quite sure LivingDeathEvent is only called after totem checks, and that is the only point at which entering grace is handled.

Jeryn99 commented 3 years ago

After asking @Jackiecrazy to test the latest commit and then testing myself; I can confirm that Totems of Undying will take priority in the next update of Regeneration. It is worth noting also, that /kill will override this functionality from my own testing, as will using the Force Regeneration Keybind.

When the next update releases, I will link the download to the file below. This may be a few days away as I am working on other things and some additional features for Regeneration.

Jackiecrazy commented 3 years ago

To add on to that, /kill does not proc totems as it deals void damage. Force regen damage is also marked as bypassing invulnerability, so it follows the same behavior.