Jeryn99 / Regeneration

Minecraft Mod - Adds the concept of Regeneration from the show Doctor who
https://minecraft.curseforge.com/projects/regeneration
GNU Lesser General Public License v3.0
31 stars 19 forks source link

[1.16.5] postRegenDuration doesnt work #446

Closed 2929762171 closed 3 weeks ago

2929762171 commented 7 months ago

Issue description

Still happen > #416 image

Steps to reproduce

No response

Minecraft version

1.16.5

Mod Loader Platform type

Forge

Mod Loader version

36.2.39

Mod version

Regeneration-36.0.6

Other relevant versions

No response

Attach the relevant crash report file or log file: (Don't know how to find a crash report file? See the Minecraft Wiki Tutorial

No response

misterplus commented 6 months ago

https://github.com/Suff99/Regeneration/blob/509dc906565498728247fd2cb3fefb5d422e281f/src/main/java/me/craig/software/regen/common/regen/RegenCap.java#L675 This is probably the relevant line to change for this issue, seems like the current config of "postRegenDuration" is used for the vanilla regeneration potion effect when regenerating(with postRegenLevel being the potion effect level).

github-actions[bot] commented 1 month ago

This issue has been marked as stale due to inactivity. If this is still a relevant issue, please comment or take action to prevent it from being closed.