search

JesJehle / earthEngineGrabR

Simplify the acquisition of remote sensing data
https://jesjehle.github.io/earthEngineGrabR/
53 stars 5 forks source link

Python sys.exit --> raise #2

Closed j08lue closed 5 years ago

j08lue commented 5 years ago

Just stubled upon this. What a system - R calling Python to interface GEE and load the data right from there into R's memory. Cool you got this to work!

Just a random note on your Python code -- don't print and then sys.exit like in

https://github.com/JesJehle/earthEngineGrabR/blob/ae6b6e91473a3e55550f0caf1a75cf946e9087d8/inst/Python/ee_get_data.py#L19-L20

Just raise ValueError(reducer) instead, or whatever exception is appropriate. And, btw, Python 2 is dead, so no more print "...". 😉

JesJehle commented 5 years ago

Thanks for the hint! The Python code is still pretty chaotic, I know. The revision is planned!