Jesper-Hustad / NoPixel-minigame

https://jesper-hustad.github.io/NoPixel-minigame/index
119 stars 89 forks source link

Make core code support the functionality in fivem-script/ #38

Open qwell opened 3 years ago

qwell commented 3 years ago

This is part of a larger effort I'm working on that will ultimately remove the fivem-script/ directory entirely.

I have NOT tested this with fivem, so it may require more work, but in theory it should.

Jesper-Hustad commented 3 years ago

This seems like a smart way of doing things. Thanks for the PR!

I personally don't have access to fiveM myself atm. so can't test it myself.

@RealDebugg if you could test this and see if it works on FiveM that would be great.

RealDebugg commented 2 years ago

I'll check this out ASAP, probably next week, but it seems as this PR is also removing some translations and UI changes made for it to work with FiveM. Try and resolve this first and then I'll make sure to check it out!

qwell commented 2 years ago

I just pushed a commit to fix the conflict that was here. Will look at the rest shortly.