Jesper-Hustad / NoPixel-minigame

https://jesper-hustad.github.io/NoPixel-minigame/index
119 stars 89 forks source link

Update language.js #69

Open ferox0132 opened 1 year ago

ferox0132 commented 1 year ago

Hello, sir! I translated the minigame into Hungarian so that Hungarian users can understand it

best regards: ferox

Jesper-Hustad commented 1 year ago

Unfortunately you made changes to the commented out version. https://en.wiktionary.org/wiki/comment_out

I can fix this to make it work tough, thanks for your translation!

ferox0132 commented 1 year ago

Thank you for your quick reply, it would be nice if it were added to the practice page as an optional language.

tewfik-ghariani commented 1 year ago

I think Jesper's remark was about how the Hungarian language was added to the language.js file

You actually edited directly the template that is commented-out ( with the // characters) Since it is commented-out, it will not be taken into account

What you have to do is to keep that commented-out section and add another section with your changes above it, but without the // characters

zsepy0525 commented 1 year ago

Hello, as I read and saw, the Hungarian translation was not included in the Minigame. My question would be what we could do about it. Thanks! Sincerely, Zepy

Jesper-Hustad commented 1 year ago

Sorry for taking so long. I thought this was already fixed.
I have added Hungarian now.
Tell me if you stumble upon any errors or bugs.
Thanks again for the translation

- Üdvözlettel, Jesper

zsepy0525 commented 1 year ago

nopixel_bank_heist_magyar_fordiras.txt Hello, I found some bugs in the system , expect the translation which is ferox's fault. I dropped you another translation but the github don't accept .js file so I upload that in .txt. Regards, zsepy

Jesper-Hustad commented 1 year ago

@zsepy0525 Those changes are implemented in the current version now.
I believe some things are being lost in translation, but I'm trying my best :D