Implement some traits, add drain, values_mut and reserve

JesperAxelsson / rust-intmap

Specialized hashmap for u64 keys

MIT License

30 stars 12 forks source link

Implement some traits, add drain, values_mut and reserve #23

Closed Aeledfyr closed 4 years ago

Aeledfyr commented 4 years ago

Closes #3, closes #7, closes #9, closes #10, closes #11, closes #12, closes #13, closes #15

This adds implementations for the following traits:

PartialEq and Eq
Clone (derived)
Debug
FromIterator

This adds the following methods:

reserve
values_mut
drain

And this changes the following methods:

keys and values (no longer take unnecessary mutable references)
- This may be a breaking change

This also adds a few tests to cover most of the new features.

JesperAxelsson commented 4 years ago

Thanks it's looking great! I only had a slight pause as the std hashmap does not implement eq and partialeq, but the kinda make sense when you think about it.

Aeledfyr commented 4 years ago

This may have changed when std switched over to hashbrown for its hashmap, but the current version has both PartialEq and Eq. Link

JesperAxelsson commented 4 years ago

Nice, I just did a cursory look and didn't find it. Your PR is merged and published :)