Closed jakoschiko closed 1 month ago
I suggest reviewing the commits separately.
Any ideas why this fails on CI? It works locally and I use the same Cargo.lock
(because it's committed).
Okay, it seemed to be a problem with MSRV. My changes triggered an update of the Cargo.toml. I was able to fix it locally by running cargo +nightly update -Z minimal-versions
. But now the serde
test fails. Maybe the test relies on a minor or patch release of serde
?
Yep, we need at least serde_json = "1.0.1"
:p
I added this to the Cargo.toml
Cargo.lock
for integration tests, should not be necessary anymore with workspace--workspace
for most commands.--all
forfmt
, I'm not sure if it does what you think it does--check
can be used without--
cargo check
cargo clippy
. I hope it's okay. I can revert this if you want.