JessThrysoee / synology-letsencrypt

94 stars 31 forks source link

Add option to installer to use different architecture #4

Closed tisba closed 1 year ago

tisba commented 1 year ago

Hi there 👋

I found your little script, which is super nice and thought me a bit on how Synology works, so thank you 🙇

I have a dated DS116 and it turns out that dpkg --print-architecture returns arm. BUT there is no matching release artefact at https://github.com/go-acme/lego/releases/latest for that. What I need here is armv7.

I'm not sure if there is a better way to find the exact architecture. /proc/cpuinfo has it somewhere, but that is probably too brittle (see below). So I added an -a option to the install script allowing you to overwrite.

I also added a check, if we can find a suitable download URL for lego and print a error message. Before I got a weird message, because curl was called without an URL, which is super confusing:

curl: no URL specified!
curl: try 'curl --help' for more information

With the changes in this PR I can do

bash install.sh -a armv7

…and it works 🥳

/proc/cpuinfo ``` processor : 0 model name : ARMv7 Processor rev 1 (v7l) BogoMIPS : 3719.16 Features : swp half thumb fastmult vfp edsp neon vfpv3 tls CPU implementer : 0x41 CPU architecture: 7 CPU variant : 0x4 CPU part : 0xc09 CPU revision : 1 processor : 1 model name : ARMv7 Processor rev 1 (v7l) BogoMIPS : 3726.54 Features : swp half thumb fastmult vfp edsp neon vfpv3 tls CPU implementer : 0x41 CPU architecture: 7 CPU variant : 0x4 CPU part : 0xc09 CPU revision : 1 Hardware : Marvell Armada 380/381/382/383/384/385/388 (Device Tree) Revision : 0000 Serial : 0000000000000000 ```
JessThrysoee commented 1 year ago

Thanks. Nice addition.