Add XPBank

[Jessassin]

Commands should be as follows:

/bank [Deposit/withdraw] [amount] /bank [balance] - return bank balance /bank [premium] - upgrade to premium account

The deposit / withdraw should only work within a bank building (defined by worldguard?) Or should not be commands, but rather signs that perform the action. This would require the player to be in a bank to perform the action in the first place.

Eventually would like the ability to write a bank note or something of that effect. It should remove the amount from your bank account, and create a piece of paper worth that amount. This note could be used to pay other players, or to purchase expensive items or property. This secondary functionality is an idea, and can wait till post-release to be implemented.

[CTMiner]

Maybe a written book and you right-click a villager? And maybe disable signing of books? I checked the wiki, and all of that is possible. Use the book_edited with the signing parameter (and something to change it so not signing or retain rest of meta), player_interact_entity to disable villager interaction and see if to get book. You can use get_meta with book into too. Syntax something like: WITHDRAW[AL] [$]100[.00] where []'d items are optional. Also, this should be the only use for (written and book+quill) books to prevent players from getting the book at the bank then using it elsewhere.

Also, not sure about WG blocking it. Last I recall, CH just intercepts commands being sent, it doesn't actually register it. Maybe it'll work, but I don't know.

[Jessassin]

Could be worth looking into. I was thinking of just adding lore to a piece of paper which contained the value of the note.

As for preventing the command outside of a bank, I was just going to use sk_current_regions and compare them to a list of "known banks" - but that is somewhat sloppy.

[CTMiner]

OH! OK! What you were thinking was a little different than what I was. I like the paper better. What if you get a paper from the villager named "Check (Draft)" (to use in preventing use for anything otherwise), have the lore be the value, then when you're done you go to the villager, right click and it changes the name to "Check" which makes it 'valid'. Also, append a color (like gold) to the start of it so player's can't rename paper to make it in an anvil (if they can anyway). This way you have the physical villager marking where the bank is. You can also right click it with a check to deposit it maybe? Maybe you can make a /check command which allows you to set the value before you 'validate' it?

[Jessassin]

The name of the item does not matter, the lore is unaffected. The only way to add lore is if you are OP, using the /give command, or if you do it through a plugin.

[Jessassin]

As for using villagers, I would rather not. Too difficult to keep track of them.

[Jessassin]

PROGRESS

XPBank was added, but still needs refinements. Notably:

Depositing and withdrawing money should take "all" as an argument Deposits and withdraws should only work within a bank Bank signs should be added, with the following attributes:

Should deposit all [bank] deposit all

Should withdraw all [bank] withdraw all

Should provide access to "premium" section of the bank (for ender chest access / other things in the future) [bank] [premium] access / teleport / door (something like this)

Should teleport a player through the iron door which has the sign placed on it.

Other things may be added later, but these are the key features that are missing.

[CTMiner]

You don't even need the door, you should be able to just open up their enderchest to them.