search

JesseChavez / activerecord-jdbc-adapter

SQL Server Adapter support on JRuby's ActiveRecord JDBC Adapter
BSD 2-Clause "Simplified" License
7 stars 5 forks source link

v61.2 has a wrong drop_table definition #16

Open stackmystack opened 1 month ago

stackmystack commented 1 month ago

This definition of the opts hash https://github.com/JesseChavez/activerecord-jdbc-adapter/blob/v61.2.0/lib/arjdbc/mssql/schema_statements.rb#L141 is dead wrong. It needs to be a **opts just like what you have on master.

The moment you call super https://github.com/JesseChavez/activerecord-jdbc-adapter/blob/v61.2.0/lib/arjdbc/mssql/schema_statements.rb#L160 it explodes.

Is there any chance you'd release a newer v61 soon? (I can see that 61.3 is dead wrong especially that it doesn't have arjdbc/mssql).

I can write the patch (because I might discover other issues that need to be fixed), I just want to know what's the pulse on the project.

stackmystack commented 1 month ago

v60 is also affected.

JesseChavez commented 1 month ago

Hi @stackmystack

it would be good if you provide a patch, I can release a patch version.

I didn't have the chance to test in several versions of sql server