Closed winnkoster closed 2 years ago
Thank you for your detailed review, unfortunately that is the entire point of this repository. Amendments are textual changes to the body of the document, legally the original document and amendments are preserved separately. The Readme states
"The United States of America's Constitution has seen many modifications over the centuries. These changes have been handled without modification of the original document through what is called an Amendment. But what does the final document look like? How did these Amendments actually change what that document said? This repository answers those questions, to the best of my ability."
You mention that the edits seem to be random and incorrect, if the edit are in fact incorrect and don't match the amendment, those are definitely of interest. Note that in some situations it my be more opinion than fact E.g the Article VIII
I noticed that many of the amendment commits add text to the main body of
Constitution.md
in addition to adding a file for each amendment (eg: the commit for Amendment XXI includes both a new file with the amendment,amendments/00021.md
, and also an edit toConstitution.md
). However, the edit to the main body ofConstitution.md
is not real and should not be included.As I looked into this further, I noticed that many amendments were erroneously scattered throughout the main text of
Constitution.md
in seemingly random (and incorrect) places. Here are some more examples I found in a quick skim:Constitution.md
(see line 15) but it should not be (see true US Constitution text for Article I Section 1)Constitution.md
(see line 496) but it should not be (see true US Constitution text for Article II Section 2)Constitution.md
but in reality there is no Article III Section 4 of the US Constitution (see link to the top of Article III)Constitution.md
(see line 724) but in reality there is no Article VIII of the US Constitution (see link to Article VII, which is the last article before amendments)Constitution.md
Article I Sections 1 and 2 and the true version. It looks to me like there may have been some git rebase/squash/force related issues, because early commits of these repo have the correct text, but later commits (this one, for example) seem to alter the text in unexpected waysI consulted the following three sources for the text of the US Constitution and they all agree that the examples I provide above are erroneous.
There may be more errors; I didn't dig too deeply into this. If you like, I'm happy to clone the repo and open a pull request with all the errors I could find, although I didn't want to just randomly open a PR on your repo without hearing from you first. Let me know, and thank you for putting so much work into this. It's a very cool project!