Blow Microphone not working

noswanson1982 commented 7 months ago

What version of melonDS DS are you using?

1.1.1

Does the problem happen in standalone melonDS?

No, it's a bug specific to melonDS DS.

What happened?

Pressing the key on the controller to activate the Blow into the microphone (as well as the white noise) does not work in game. (Specific game being played is Mario & Luigi: Bowser's Inside Story). I can pass the Mic Test with flying colors, but in sequences that require blowing into the microphone, it does not work.

However, it does work perfectly fine in the regular MelonDS core. This is a shame cause the regular MelonDS core doesn't have screen rotation, while the one with screen rotation, doesn't have a working microphone mode.

What should've happened instead?

Holding down the key for the microphone (or toggling it with toggle mode active) should allow Bowser to blow fire in those game sequences like what happens in MelonDS by doing the same thing, configured the same way.

Which platforms do you see the problem on?

[X] Windows
[ ] macOS
[ ] Linux
[ ] Android
[ ] iOS
[ ] tvOS
[ ] Other (specify below)

Which versions of the OS?

Windows 10

Which libretro frontend are you using?

Retroarch 1.17.0 Steam with MelonDS DS added

Terms

[X] I agree to follow the code of conduct.
[X] I understand that melonDS DS is not developed or maintained by the authors of melonDS.
[X] I understand that this form is for reporting bugs, not for requesting help.
[X] I understand that the author develops this core in his spare time, and that he is under no obligation to respond to this bug report.

JesseTG commented 7 months ago

I'll investigate this, but are you unable to use a real microphone? The Windows build of RetroArch does have working mic drivers.

noswanson1982 commented 7 months ago

I suppose I could look into that, once I track down an actual microphone. I do like the convenience of being able to hold down a trigger on my controller and just having it work (albeit playing sideways does really suck) with MelonDS.

JesseTG commented 20 hours ago

I am now working on this ticket. Some notes as to the cause:

The DS microphone is cheap and low-quality; a lot of games that ask you to blow into it expect samples that are highly clipped (i.e. louder than it can handle). However, your real microphone may be mitigating this clipping, so I'll need to apply some gain.
Applying gain to the white noise provided by Noise mode does make it more useful; it enables the puzzle that @MonstrHuntr outlined in #227 to be solved reliably.
Blow mode is broken because...I forgot to implement it. Whoops.

JesseTG commented 1 hour ago

@MonstrHuntr @noswanson1982 @oddballparty @Lachlan928 This has now been addressed! The next release will include this fix, but if you're itching to try it you can get a dev build that includes it here once it's ready.

oddballparty commented 1 hour ago

@MonstrHuntr @noswanson1982 @oddballparty @Lachlan928 This has now been addressed! The next release will include this fix, but if you're itching to try it you can get a dev build that includes it here once it's ready.

Amazing! Thank you so much!!!

JesseTG / melonds-ds