search

JesseVelden / SwipyFolders

📱 Gestures for your folders! (Jailbreak)
MIT License
17 stars 7 forks source link

Fix actions happening multiple times #12

Closed michyprima closed 7 years ago

michyprima commented 7 years ago

This is required because setIcon is called multiple times in iOS 10, causing multiple recognizers to be added. Example: I have the Open Folder action on swipe up. The folder opens multiple times, requiring multiple touches outside its border to close it.

JesseVelden commented 7 years ago

Awesome! I had the same problem in the simulator, so I was thinking it was an issue that was related to iOS 11 as I didn't have the problem on my iOS 10 iPhone. Thanks for contributing.

michyprima commented 7 years ago

You are welcome!

Unrelated: Could you consider adding back the Long Press gesture (disabled by default / with an appropriate warning)? It's working fine on my 6S and I really love it. I'm currently adding it back myself but would be great not having to patch the source every time or using a substrate plugin for this

JesseVelden commented 7 years ago

Sure thing! I will update it soon

JesseVelden commented 7 years ago

Consider it done 🎉 f37c70cc4ae92f409f8535abb185686d12cf5798

I think the next update will be dynamically reset icons (and call setIcon) after preferences get changed, so that no respring will be necessary.

michyprima commented 7 years ago

That's awesome of you, thanks! I can finally revert to the official version :P

I suggest opening a separate issue if you wanna discuss this :)