search

JesseWebDotCom / webtrees-theme-modern

A theme for webtrees, optimized for a mobile and modern experience
22 stars 3 forks source link

"About" summary is not translatable #10

Closed hartenthaler closed 1 year ago

hartenthaler commented 1 year ago

At the moment this nice new tab is a mixture of English and German (when using German as webtrees language). Maybe a first step could be to make it consistent in English only. As a second step, it would be nice to make it translatable like the narrative style of JustCarmens custom module Fancy TreeView.

JesseWebDotCom commented 1 year ago

let me see if this is something I can do (reminder: I have no idea on how to create a webtrees theme. I'm just hacking my way through it to create something I and my family would want to use).

hartenthaler commented 1 year ago

... ok, but you are really good at doing it that way! Maybe expand your family by adopting some members that are speaking other languages than English ... ;-)

JesseWebDotCom commented 1 year ago

Never used Fancy Treeview but just checked it out and it does a similar summary to my "About" tab. I will try to reverse engineer what its doing and incorporate into my theme.

JesseWebDotCom commented 1 year ago

And maybe I can turn this into a separate module (and separate it from the theme) - we'll see how it goes

hartenthaler commented 1 year ago

And maybe I can turn this into a separate module (and separate it from the theme)

That is a good idea because this function is a new "tab" and it should not be mixed up with the "theme" function of "modern".

JesseWebDotCom commented 1 year ago

Successfully created a separate module for the about tab. Going to take me a while to rewrite - so it includes some fixes as well as language support.

JesseWebDotCom commented 1 year ago

This theme has been completely rewritten: https://github.com/JesseWebDotCom/webtrees-theme-modern/releases/tag/0.0.1

The feature you were using is no longer available in this release. It will return (either in the theme itself or as a separate module) after the theme is stable and I get experience with translation based projects.