JesseWebDotCom / webtrees-theme-modern

A theme for webtrees, optimized for a mobile and modern experience
22 stars 3 forks source link

Translation issue with 'you' #30

Closed TheDutchJewel closed 1 year ago

TheDutchJewel commented 1 year ago

There is a problem with the new string you in the Facts and events tab when using a non-English translation.

If you select yourself in the family tree, the English translation shows you, which is correct: en

But in Dutch I see je hijzelf instead of jij: nl

and in German dein er selbst instead of du: du

JesseWebDotCom commented 1 year ago

Thanks - based on what you’re seeing, I know what the issue is and how to fix

JesseWebDotCom commented 1 year ago

Try this: https://github.com/JesseWebDotCom/webtrees-theme-modern/releases/tag/0.1.0

TheDutchJewel commented 1 year ago

The new version also does not work correctly when using a non-English translation.

In Dutch I see jouw hijzelf which should be jij.

And in German I see dein er selbst which should be du.

JesseWebDotCom commented 1 year ago

Redownload and apply same 0.1.0 release again (I just fixed it)

TheDutchJewel commented 1 year ago

Working fine now. Thank you!

TheDutchJewel commented 1 year ago

I updated the Dutch translation. See pull request#32.

TheDutchJewel commented 1 year ago

Every version is released with 'your' ='jouw' instead of 'je', so I have to update it again.

See pull request #39.

JesseWebDotCom commented 1 year ago

merged