search

JesseWebDotCom / webtrees-theme-modern

A theme for webtrees, optimized for a mobile and modern experience
22 stars 3 forks source link

In "settings" Copyright name and URL is necessary even if this option is disabled #8

Closed hartenthaler closed 1 year ago

hartenthaler commented 1 year ago

When disabling this option it should not be necessary to specify the name and URL for copyright.

JesseWebDotCom commented 1 year ago

I don't know how to do that. Can you point me to an existing webtrees module that has a settings page where unchecking of an option displays/hides other options.

hartenthaler commented 1 year ago

Oh, no it is not about hiding. It is about that you check if there is content in Copyright Name and URL. It makes no sense to deselect the copyright option and nevertheless have to put content to those fields.

JesseWebDotCom commented 1 year ago

Good news - this theme has been completely rewritten and your issue has been addressed: https://github.com/JesseWebDotCom/webtrees-theme-modern/releases/tag/0.0.1