search

Jessecar96 / SteamBot

Automated bot software for interacting with Steam Trade
http://scrap.tf
MIT License
1.34k stars 910 forks source link

Some people know how to trick the bots... #219

Closed SuperMari0s closed 11 years ago

SuperMari0s commented 11 years ago

So i saw that happening and asked him and he admitted it and he said he was looking for more bots to trick and get the keys for less...

It has to do with #188

Basically he was adding and removing invalid items and then hit ready fast. at some point the bot missed the removed item and traded the key for less.

Here is the log for more info: http://pastebin.com/EaSB5aPg

gamemaster1494 commented 11 years ago

So he adds a weapon, bot says dude your stupid and while the bot is saying that it skips him remove metal?

SuperMari0s commented 11 years ago

Something like that. but it's not only about an invalid item. it's about the one missing remove event that happens rarely. if you keep adding/removing even a scrap more chances to happen and it's not rare anymore.

gamemaster1494 commented 11 years ago

I hooked into the trade.otheritemsoffered and changed the event checking and i haven't had the problem since...

SuperMari0s commented 11 years ago

@gamemaster1494 how can i do that?

cwhelchel commented 11 years ago

I hooked into the trade.otheritemsoffered and changed the event checking and i haven't had the problem since...

Do a pull request so we can see what you did and if it's generally useful, merge it into Steambot.

gamemaster1494 commented 11 years ago

Not really hooked into, but made the otheroffereditems public, as well as mine, and checked off that, to be sure all events triggered. If steam side sends it, then its gotta be right. I'll show what i did tomorrow/monday. Really tired and need to get to bed.

SuperMari0s commented 11 years ago

Thank you @gamemaster1494 we are waiting for your post to see what you did :)

gamemaster1494 commented 11 years ago

There ya go ^^

The hooking into Trade.otherofferedItems hasn't shown anything helpful, as i have messages to show if it catches something if the events don't trigger right, but it has never fired.

SuperMari0s commented 11 years ago

Thank you very much @gamemaster1494 i'm looking into it along with the suggestion of the others.

teliosdev commented 11 years ago

This is still an issue as the pull request has not been merged with the master branch yet.

SuperMari0s commented 11 years ago

Sorry @redjazz96 my bad. let's keep it around until the pull is merged :)