Jessecar96 / SteamBot

Automated bot software for interacting with Steam Trade
http://scrap.tf
MIT License
1.33k stars 910 forks source link

Accepting a valid trade as an F2P account hangs SteamBot #348

Closed ausey00 closed 11 years ago

ausey00 commented 11 years ago

Hi All,

I've come across a situation where SteamBot hangs when executing Trade.AcceptTrade() in the OnTradeAccept method. The Debug logs show no error or warnings.

The trade being made as an example is whereby an F2P account is offering a Name Tag to a premium account. A trade of a name tag, paint, or description tag is possible from an F2P account to a premium account using steam's GUI.

I have validated the items being offered in the trade, and the F2P account is offering only a name tag, and the PTP account is offering nothing.

Should I attempt a trade with a premium account for any item, the trade completes successfully.

Debugging further than I have done so far is beyond my current knowledge; so I thought I'd post this before I go any further and start making changes.

I'll continue to look into this, but if anyone has any insight, that would be great.

Austin

EDIT:title to make it more relevant

ausey00 commented 11 years ago

I am using a modified Userhandler, but have stripped it back to be no different than adminuserhandler I'll test this out and get back to you.

The steps you described are where the F2P is the person interacting with the bot. I described the F2P as being the bot.

The code in OnTradeAccept is short, but works when the bot is not F2P.

Austin

ausey00 commented 11 years ago

Here's the OnTradeAccept method i'm using - Very similar to the AdminUserHandler

    public override void OnTradeAccept()
    {
        Thread.Sleep(delay);
        Log.Info("Other account accepted trade");
        bool ok = Trade.AcceptTrade();
        Log.Info("I have executed trade command");
        if (ok)
        {
            Log.Success("Trade was Successful!");
        }
        else
        {
            Log.Error("Trade might have failed.");
        }
    }
ausey00 commented 11 years ago

Ah, it's a bug in my code. I'll close this. Apologies I erroneously coded to log items being added to trade, when they weren't.