Jessecar96 / SteamBot

Automated bot software for interacting with Steam Trade
http://scrap.tf
MIT License
1.33k stars 910 forks source link

TradeExeception was unhandled by user code #452

Closed ynoTL23 closed 11 years ago

ynoTL23 commented 11 years ago

Let me start off by saying I'm sorry if this doesn't really relate to SteamBot. You can go ahead and close this if it isn't related. But as far as I know, the trouble is located inside SteamTrade.Trade.cs which is I guess part of SteamBot.

So I am using a custom UserHandler for keybanking and when the user types ".additems", the bot will add all metal and keys from its backpack. However, after about 4 scraps were added, Visual Studio gives an error saying: TradeExeception was unhandled by user code leading to SteamTrade.Trade.cs

I have no idea what the issue is. The exeception seems to be handled by default when cloned from GitHub as it throws a new TradeExeception with a string. And again, sorry if this isn't really SteamBot related, delete this if it is necessary.

waylaidwanderer commented 11 years ago

What's the full stack trace? Just guessing since we can't see what the error is, you might be trying to add an untradeable item.

ynoTL23 commented 11 years ago

The command, ".additems" is just this:

if (message == ".additems")
                {
                    Trade.AddAllItemsByDefindex(5000);
                    Trade.AddAllItemsByDefindex(5001);
                    Trade.AddAllItemsByDefindex(5002);
                    Trade.AddAllItemsByDefindex(5021);
                }

Simple and the items are tradable metal and keys. But when the command is executed, it takes me to Visual Studio, into SteamTrade.Trade.cs and displays this: Error

waylaidwanderer commented 11 years ago

I'm almost 99 percent certain your code is causing the bot to try to add an untradeable metal which would cause the crash.

ynoTL23 commented 11 years ago

I don't know how any of my metal is untradeable. According to backpack.tf's backpack viewer and TF2B's backpack viewer, all my metal and keys are tradeable. The code from the custom UserHandler and the SteamBot code all do not have errors except for the 2 warnings about CSharpBinding, etc.

ynoTL23 commented 11 years ago

Ah, so the items that were crafted by the account before it was turned into a bot cannot be traded since the bot is F2P. If I deleted the untradeable items, will that simply solve the problem? I suppose it will.

ynoTL23 commented 11 years ago

Woah! Hah weird. I didn't notice it was you who responded with the F2P information, I thought it was waylaidwanderer because I wasn't reading the names, just the comments.

But thanks for the info guys, I'll just close this issue now.

P.S. I'm kinda 12 hours late but, I hope the scrap.tf exploits don't happen again anytime soon. I'd be glad to donate.