Jessecar96 / SteamBot

Automated bot software for interacting with Steam Trade
http://scrap.tf
MIT License
1.33k stars 910 forks source link

Big issues with trade acceptance #598

Closed glen-84 closed 9 years ago

glen-84 commented 10 years ago

I have seen 2 issues today, which has meant that we have had to take our bots offline:

  1. A trade is accepted and "committed", no OnTradeSuccess, and much later (like 20 mins), there is a trade error. EXAMPLE
  2. A trade is accepted and "committed", and much later (like 20 mins), OnTradeSuccess is invoked. EXAMPLE

What is happening!?

Edit: The bots are running on Linux, if that makes any difference.

scholtzm commented 10 years ago

Well you could either check users/bots backpack or visit the inventoryhistory page and check there.

glen-84 commented 10 years ago

I added some more debugging code:

[2014-09-23 20:22:03] AddItemWebCmd FAIL: JSON SUCCESS IS FALSE (itemid: 4647699107, contextid: 2) -- {"success":false,"error":"Could not find a trading session"}
[2014-09-23 20:22:04] AddItemWebCmd FAIL: JSON SUCCESS IS FALSE (itemid: 4647699107, contextid: 2) -- {"success":false,"error":"Could not find a trading session"}
[2014-09-23 20:22:05] AddItemWebCmd FAIL: JSON SUCCESS IS FALSE (itemid: 4647699107, contextid: 2) -- {"success":false,"error":"Could not find a trading session"}
[2014-09-23 20:23:31] AddItemWebCmd FAIL: JSON SUCCESS IS FALSE (itemid: 4648867841, contextid: 2) -- {"success":false,"error":"Could not find a trading session"}
[2014-09-23 20:23:33] AddItemWebCmd FAIL: JSON SUCCESS IS FALSE (itemid: 4648867841, contextid: 2) -- {"success":false,"error":"Could not find a trading session"}
[2014-09-23 20:23:34] AddItemWebCmd FAIL: JSON SUCCESS IS FALSE (itemid: 4648867841, contextid: 2) -- {"success":false,"error":"Could not find a trading session"}
[2014-09-23 20:29:34] AddItemWebCmd FAIL: JSON SUCCESS IS FALSE (itemid: 4648854789, contextid: 2) -- {"success":false,"error":"Could not find a trading session"}
[2014-09-23 20:29:35] AddItemWebCmd FAIL: JSON SUCCESS IS FALSE (itemid: 4648854789, contextid: 2) -- {"success":false,"error":"Could not find a trading session"}
[2014-09-23 20:29:36] AddItemWebCmd FAIL: JSON SUCCESS IS FALSE (itemid: 4648854789, contextid: 2) -- {"success":false,"error":"Could not find a trading session"}

Note: This is running from a single static IP.

scholtzm commented 10 years ago

It's happening now a lot. Steam is being extremely slow today and lots of trades ends with status 2 even though the items are transferred. This is definitely a Steam issue and I'm not sure we can fix this. The only way I can think of is checking inventoryhistory page since the trade itself sends false data.

glen-84 commented 10 years ago

I'm busy cleaning up a big mess now, about 20 failed transactions before I stopped our bots. :angry:

glen-84 commented 10 years ago

I put the bots back up for about 5 seconds, and the first trade gave the same error.

BlueRaja commented 10 years ago

I can't seem to get trades to work at all today (even with other humans).

My first trade with my bot, I saw this: http://screencast.com/t/dqOA4kXsBr, after which I got the "forever declines all requests" bugs.

I cannot use dispenser.tf because trade-offers give "An error was encountered while processing your request:" every time.

So, I'm pretty sure this is due to shoddy Steam servers, not the bot.

FrozenHaxor commented 10 years ago

I confirm that, it is definitely Steam. API requests take about 5 seconds minimum and lots of stuff just times out.

glen-84 commented 9 years ago

We just had a case where OnTradeSuccess was called and the trade was neither ready nor accepted.

Hopefully it's just a one-off thing.