Is my improvement to Bot.AcceptAllMobileTradeConfirmations() wanted/needed?

[ThereWasADream]

See link at bottom. While trying a merger of /u/waylaidwanderer 's TradeOffersBot repo and vanilla SteamBot, I found a way to avoid some of the session and cookie issues that sometimes make this confirmation method fail. Waylaid made a commit about the same idea except his was better of course since I'm a novice. However I prefer my own method as it has a more aggressive method of ensuring every trade is confirmed.

Assuming A. I am not the only one who has had this issue and B. You all are interested

I am considering making a small pull request to update the method. It's a combination of the method I put together and a slightly different method /u/waylaidwanderer added to his own repo last night. Assuming he has no objections I think it'd be wrong not to share.

Here it is in my own repo: https://github.com/ThereWasADream/KeyBot/blob/master/SteamBot/Bot.cs#L1284

[BlueRaja]

? This is not a pull-request. To create a pull-request, go to the pull-request tab in the top and click 'new pull request'.

You will probably want to create a new branch for the PR, so you can continue to add things to your master-branch while the PR is open.

[waylaidwanderer]

I fixed an issue with that code by the way: https://github.com/waylaidwanderer/SteamTradeOffersBot/commit/5a6ceac043bacd42670d35e46a4ef5e36f6b045d

By the way, sometimes confirmations won't appear, so checking for confirmations == 0 is faulty logic here: https://github.com/ThereWasADream/KeyBot/blob/master/SteamBot/Bot.cs#L1305. Also a shorter way to do that would be SteamGuardAccount.FetchConfirmations().Length == 0.

[ThereWasADream]

BlueRaja, you are confused because you did not read the post.

waylaidwanderer cleared this up - this will not work. This should just be closed.