Peer-to-peer code review - Githubissues

Jessekay / My-portfolio

MIT License

0 stars 0 forks source link

Peer-to-peer code review #8

Open MarwanDev opened 1 year ago

MarwanDev commented 1 year ago

Great job so far. Excellent design of both mobile and desktop views. Very few changes need to be applied, and your project would be perfect

I can see that hover is only applied to the last button in the contact section. Can you please add the hover to the rest of the buttons?
I can see that the title of the page is "My Portfolio", which is not the best option when it comes to accessibility. As a user tends to open multiple tabs at the same time, a catchy name is preferred so that the user can find it easily. A good example of a page title could be "Jesse - full-stack developer"

mercymugambi commented 1 year ago

Your have documented your project in a professional way. You code base looks clean and on accessibility, you've followed best practices.

However, there are is an issue you need to fix. I would advice you work with percentages on widths on mobile in order for it to adjust to new width when scaled up