JessicaNgo / TeleGiphy

WebApp for demoday
MIT License
2 stars 0 forks source link

Logic Error in Giphy Test #100

Closed zapplecat closed 7 years ago

zapplecat commented 7 years ago

Currently responses.add and the expected results both come from the same file. Which, later in the assert item in resp.json() will always match exactly, even if the loaded file is not the intended file.

For example, I can load translate_200.json and still pass a 403 test since the response has a status of 403 and the file matches expected.

zapplecat commented 7 years ago

I am addressing this on the giphy_funnel branch atm

zapplecat commented 7 years ago

This is addressed in this commit 3f1adbef4d913a14c041ffdb5471e168c0f3b6c7