search

Jesulonimi21 / Swift-Algorand-Sdk

A Swift Sdk for interacting with the Algorand Blockchain
MIT License
19 stars 13 forks source link

fixing compiling issue #10

Closed yulianiii closed 2 years ago

yulianiii commented 2 years ago

project is currently blocked from compiling.

Jesulonimi21 commented 2 years ago

@yulianiii Please could you add a better description to this PR so i can better understand the value you are trying to provide. I appreciate the PR thanks

stefanomondino commented 2 years ago

@Jesulonimi21 I think the problem is that CryptoKit is only iOS 13+ (same for macos, tvos and watchos), while the Package.swift file declares compatibility starting from iOS 10. Is CryptoKit really necessary? Does it work without it?

Jesulonimi21 commented 2 years ago

@stefanomondino @yulianiii Thanks. Could @yulianiii just delete the line instead of commenting it out since its not used

Jesulonimi21 commented 2 years ago

The delete of cryptokit has been added to the main branch already Thanks for your contribution, if there is more you want to add relating to this, you can reopen this PR or create a new PR