Jesus / dropbox_api

Ruby client library for Dropbox API v2
MIT License
171 stars 113 forks source link

Fix Content-Length error #31

Closed Jesus closed 7 years ago

Jesus commented 7 years ago

Hi @simi,

just to speed things up, I've pulled your tests from Mavvie's repo and included them in this new PR.

I've also modified the tests to correct a mistake and try to improve them.

I understand that what I've considered "improving" them may be biased. So I've decided to leave this PR open for your review and open discussion. I'll leave this open for a few days.

Also, here's some explanation why I think this is better:

simi commented 7 years ago

@Jesus I think it will be ok to just strip newlines inside it blocks. Thanks for mistake fix and I see point for other changes. You're the boss here, so I have no problem with this style.

Jesus commented 7 years ago

This has been published in the last version of the gem: 0.1.9