search

Jesus / dropbox_api

Ruby client library for Dropbox API v2
MIT License
171 stars 113 forks source link

Add chunked uploader #34

Closed vtm9 closed 6 years ago

vtm9 commented 7 years ago

Add chunked uploader

Jesus commented 7 years ago

I'm not sure I want to get this merged into the codebase just because I had planned to just cover the whole Dropbox API with a one-to-one mapping.

I was considering writing a second higher level library that would depend on this one to implement these cooler features that rely on the lower level API calls from here. So this patch would belong to the higher level library.

So, I need some time to think about this.

vtm9 commented 7 years ago

@Jesus, Thanks for answer. It's good idea to separate abstractions from api. But, in my opinion, simple abstractions in api gem are very convenient, until the sdk-library is done.

evolve2k commented 6 years ago

Hi I'd like to contribute that I think this inclusion would be very welcomed. I think it's a basic enhancement that anyone that want to use the incremental upload would otherwise be stuck having to code up. I think also it's a good inclusion to add and then if need be later if you create a higher order gem you can refactor it out then.

Thanks for your work on this gem it's been very useful.