Allow also any 1.x faraday dependency version.

Jesus / dropbox_api

Ruby client library for Dropbox API v2

MIT License

171 stars 113 forks source link

Allow also any 1.x faraday dependency version. #72

Closed simi closed 3 years ago

simi commented 4 years ago

closes #71

jrochkind commented 3 years ago

Why <= 1.1? If Faraday uses semantic versioning, then it should be backwards compat up to 2.0, would it make more sense to say > 2, or ~> 1.0?

simi commented 3 years ago

It is safe to move incrementally. Anyway I'm ok to change to < 2. @Jesus WDYT?

simi commented 3 years ago

@Jesus pingie

jrochkind commented 3 years ago

Hi, Faraday is up to 1.3.0 release, anyone using dropbox_api can still only use faraday 1.0.0 exactly.

A merge and release would be really helpful! I am considering forking this to allow more recent faraday, but would really rather not!

jrochkind commented 3 years ago

However note that this PR still wouldn't allow faraday 1.3.0, it owuld only allow 1.1.x!

I think it really needs to allow < faraday 2, to keep this problem from happening again, since it has been demonstrated that it's difficult to get updates to dropbox_api to happen, let's fix it so we don't need to do this again in a month!

simi commented 3 years ago

@jrochkind I have updated the PR.

@Jesus any plan on merge & release? Anything I can help with?

Jesus commented 3 years ago

Oops I hadn't seen those notifications until now, sorry!

simi commented 3 years ago

@Jesus thanks! Any plans for release?