Jesus / dropbox_api

Ruby client library for Dropbox API v2
MIT License
171 stars 113 forks source link

update to 2.x of `oauth` gem as dependency? #96

Open jrochkind opened 1 year ago

jrochkind commented 1 year ago

dropbox_api requires oauth1 gem 1.x

https://github.com/Jesus/dropbox_api/blob/11bd1cf5f9a3683f1956857f9187b68134a7eddd/dropbox_api.gemspec#L24

However, oauth gem now has a 2.0 release as of June 2022. https://rubygems.org/gems/oauth2/versions/2.0.0

Instalilng the last oauth2 1.x release produces this warning:

You have installed oauth2 version 1.4.11, which is EOL.
No further support is anticipated for the 1.4.x series.

OAuth2 version 2 is released.
There are BREAKING changes, but most will not encounter them, and upgrading should be easy!

We have made two other major migrations:
1. master branch renamed to main
2. Github has been replaced with Gitlab

Please see:
• https://gitlab.com/oauth-xx/oauth2#what-is-new-for-v20
• https://gitlab.com/oauth-xx/oauth2/-/blob/main/CHANGELOG.md
• https://groups.google.com/g/oauth-ruby/c/QA_dtrXWXaE

Please upgrade, report issues, and support the project! Thanks, |7eter l-|. l3oling

Could dropbox_api be updated to allow use of oath2 2.x, perhaps allowing both 1.x and 2.x?

jrochkind commented 1 year ago

hi! i'm curious if anyone is currently around maintaining this gem!

I could try a PR as above, would anyone be here to review/merge it?

Laykou commented 1 year ago

@Jesus Are you still in charge of this gem, please? We would also really benefit of updating the oauth2 dependency

rainerborene commented 1 year ago

@Jesus I can maintain this gem if you're not interested anymore. Need help with this issue as well.