JesusEV / nest-simulator

The NEST simulator
GNU General Public License v2.0
1 stars 0 forks source link

Refactor buffering of spiking variable #13

Closed akorgor closed 6 months ago

akorgor commented 6 months ago

This PR aims to clarify the buffering of the spiking variable z in the compute_gradient_function and comprises the following changes:

  1. rename t_previous_spike to t_spike_previous to emphasize the relationship to t_spike
  2. rename previous_z_buffer to z_previous_buffer and pre to z_current_buffer to emphasize the relationship to z
  3. replace the while loop with a for loop in which t is locally defined and eprop_hist_it and t are incremented
  4. change the position of t_spike and t_spike_previous + P_.eprop_isi_trace_cutoff_ in std::min since t_spike_previous is chronologically earlier than t_spike (to enhance readability)