search

JesusEV / nest-simulator

The NEST simulator
GNU General Public License v2.0
1 stars 0 forks source link

Unify overloaded `erase_used_eprop_history` functions #5

Closed akorgor closed 5 months ago

akorgor commented 5 months ago

This PR aims to avoid the redefinition of it_eprop_hist_from and it_eprop_hist_to and establish a consistent variable naming between the two overloaded erase_used_eprop_history functions. Furthermore, it removes _erase_ in one set of variable names since it is misleading that the iterators without _erase_ are also used in the erase function. For lack of more expressive names, the two sets of iterators are distinguished by the suffix _1 and _2.

JesusEV commented 5 months ago

@akorgor Would you please clarify:

"Furthermore, it removes erase in one set of variable names since it is misleading that the iterators without erase are also used in the erase function"

I could not find where this removal is happening

akorgor commented 5 months ago

@akorgor Would you please clarify:

"Furthermore, it removes erase in one set of variable names since it is misleading that the iterators without erase are also used in the erase function"

I could not find where this removal is happening

eprop_archiving_node_impl.h l.177

JesusEV commented 5 months ago

@akorgor Maybe _1 and _2 are not the most satisfactory names but I can't think of a better alternative