JesusFilm / core

JFP DS Engineering Monorepo
https://docs.core.jesusfilm.org/
18 stars 11 forks source link

fix: tidy up spacing for toolbar #3648

Closed edmonday closed 3 days ago

edmonday commented 3 days ago

Description

Issue

Small fixes to spacing in toolbar as requested by Lyuba.

linear[bot] commented 3 days ago

ENG-1165 Tidy up ui for top bar -no qa

codecov[bot] commented 3 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.22%. Comparing base (5b59140) to head (2e8991f). Report is 12 commits behind head on main.

:exclamation: There is a different number of reports uploaded between BASE (5b59140) and HEAD (2e8991f). Click for more details.

HEAD has 66 uploads less than BASE | Flag | BASE (5b59140) | HEAD (2e8991f) | |------|------|------| |libs.shared.ui|6|0| |libs.nest.common|6|0| |libs.journeys.ui|6|0| |apps.journeys|6|0| |libs.nest.decorators|2|0| |apps.journeys-admin|6|3| |libs.nest.powerBi|4|0| |apps.api-journeys|6|0| |apps.watch|5|0| |apps.api-users|6|0| |apps.api-media|6|0| |apps.api-languages|6|0| |apps.api-analytics|4|0|
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3648 +/- ## ========================================== - Coverage 89.32% 80.22% -9.11% ========================================== Files 1144 638 -506 Lines 17851 9972 -7879 Branches 2315 1301 -1014 ========================================== - Hits 15946 8000 -7946 - Misses 1663 1818 +155 + Partials 242 154 -88 ``` | [Flag](https://app.codecov.io/gh/JesusFilm/core/pull/3648/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | Coverage Δ | | |---|---|---| | [apps.api-analytics](https://app.codecov.io/gh/JesusFilm/core/pull/3648/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | | [apps.api-journeys](https://app.codecov.io/gh/JesusFilm/core/pull/3648/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | | [apps.api-languages](https://app.codecov.io/gh/JesusFilm/core/pull/3648/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | | [apps.api-media](https://app.codecov.io/gh/JesusFilm/core/pull/3648/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | | [apps.api-users](https://app.codecov.io/gh/JesusFilm/core/pull/3648/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | | [apps.journeys](https://app.codecov.io/gh/JesusFilm/core/pull/3648/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | | [apps.journeys-admin](https://app.codecov.io/gh/JesusFilm/core/pull/3648/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `80.22% <ø> (ø)` | | | [apps.watch](https://app.codecov.io/gh/JesusFilm/core/pull/3648/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | | [libs.journeys.ui](https://app.codecov.io/gh/JesusFilm/core/pull/3648/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | | [libs.nest.common](https://app.codecov.io/gh/JesusFilm/core/pull/3648/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | | [libs.nest.decorators](https://app.codecov.io/gh/JesusFilm/core/pull/3648/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | | [libs.nest.powerBi](https://app.codecov.io/gh/JesusFilm/core/pull/3648/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | | [libs.shared.ui](https://app.codecov.io/gh/JesusFilm/core/pull/3648/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 3 days ago

The latest updates on your projects.

Name Status Preview Updated (UTC)
journeys-admin ✅ Ready Visit Preview Mon Oct 14 00:08:44 UTC 2024