search

JesusFilm / core

JFP DS Engineering Monorepo
https://docs.core.jesusfilm.org/
18 stars 11 forks source link

fix: eng 1091 upload video error #3649

Open scottkelso opened 3 days ago

scottkelso commented 3 days ago

Description

Issue

If an upload video error occurs but the user tries again, there error text still remains as well as the uploading/processing text

Link to Linear Todo

Solution

Set error state to false onDrop

External Changes

Refactored test class

How to test

When a video upload error occurs (maybe forced by network change eta), the user should be able to retry again. On another attempt you should never have both the old error text and the new uploading/processing text together.

linear[bot] commented 3 days ago

ENG-1091 Upload Video Error

codecov[bot] commented 3 days ago

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.24%. Comparing base (eaa263f) to head (32eb25c). Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...ibrary/VideoFromCloudflare/AddByFile/AddByFile.tsx 25.00% 3 Missing :warning:

:exclamation: There is a different number of reports uploaded between BASE (eaa263f) and HEAD (32eb25c). Click for more details.

HEAD has 67 uploads less than BASE | Flag | BASE (eaa263f) | HEAD (32eb25c) | |------|------|------| |libs.shared.ui|6|0| |libs.nest.common|6|0| |libs.journeys.ui|6|0| |apps.journeys|6|0| |apps.journeys-admin|6|3| |apps.api-journeys|6|0| |apps.watch|6|0| |apps.api-users|6|0| |apps.api-media|6|0| |apps.api-languages|6|0| |libs.nest.decorators|2|0| |libs.nest.powerBi|4|0| |apps.api-analytics|4|0|
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3649 +/- ## ========================================== - Coverage 89.32% 80.24% -9.09% ========================================== Files 1144 639 -505 Lines 17856 9972 -7884 Branches 2317 1301 -1016 ========================================== - Hits 15950 8002 -7948 - Misses 1663 1816 +153 + Partials 243 154 -89 ``` | [Flag](https://app.codecov.io/gh/JesusFilm/core/pull/3649/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | Coverage Δ | | |---|---|---| | [apps.api-analytics](https://app.codecov.io/gh/JesusFilm/core/pull/3649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | | [apps.api-journeys](https://app.codecov.io/gh/JesusFilm/core/pull/3649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | | [apps.api-languages](https://app.codecov.io/gh/JesusFilm/core/pull/3649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | | [apps.api-media](https://app.codecov.io/gh/JesusFilm/core/pull/3649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | | [apps.api-users](https://app.codecov.io/gh/JesusFilm/core/pull/3649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | | [apps.journeys](https://app.codecov.io/gh/JesusFilm/core/pull/3649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | | [apps.journeys-admin](https://app.codecov.io/gh/JesusFilm/core/pull/3649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `80.24% <50.00%> (+0.02%)` | :arrow_up: | | [apps.watch](https://app.codecov.io/gh/JesusFilm/core/pull/3649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | | [libs.journeys.ui](https://app.codecov.io/gh/JesusFilm/core/pull/3649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | | [libs.nest.common](https://app.codecov.io/gh/JesusFilm/core/pull/3649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | | [libs.nest.decorators](https://app.codecov.io/gh/JesusFilm/core/pull/3649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | | [libs.nest.powerBi](https://app.codecov.io/gh/JesusFilm/core/pull/3649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | | [libs.shared.ui](https://app.codecov.io/gh/JesusFilm/core/pull/3649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 3 days ago

The latest updates on your projects.

Name Status Preview Updated (UTC)
journeys-admin ✅ Ready Visit Preview Mon Oct 14 22:53:31 UTC 2024