JesusFilm / core

JFP DS Engineering Monorepo
https://docs.core.jesusfilm.org/
18 stars 11 forks source link

refactor: contained cover #3666

Open csiyang opened 1 day ago

csiyang commented 1 day ago

Description

Issue

Too much spaced used in the image area for contained cover

Solution

Add a parallax scroll to hide the image when there is overscroll

linear[bot] commented 1 day ago

DES-45 Card layout fixes

github-actions[bot] commented 1 day ago
Fails
:no_entry_sign: Please request a reviewer for this PR.

Generated by :no_entry_sign: dangerJS against 5cec7d14ff1ac354aa96d40a3e295c3f22f2761b

codecov[bot] commented 1 day ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.59%. Comparing base (1751d15) to head (5cec7d1). Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...rc/components/Card/ParallaxCover/ParallaxCover.tsx 0.00% 2 Missing :warning:

:exclamation: There is a different number of reports uploaded between BASE (1751d15) and HEAD (5cec7d1). Click for more details.

HEAD has 6 uploads less than BASE | Flag | BASE (1751d15) | HEAD (5cec7d1) | |------|------|------| |apps.api-media|6|0|
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3666 +/- ## =========================================== - Coverage 91.84% 79.59% -12.25% =========================================== Files 145 854 +709 Lines 1471 14560 +13089 Branches 179 1922 +1743 =========================================== + Hits 1351 11589 +10238 - Misses 93 2685 +2592 - Partials 27 286 +259 ``` | [Flag](https://app.codecov.io/gh/JesusFilm/core/pull/3666/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | Coverage Δ | | |---|---|---| | [apps.api-journeys](https://app.codecov.io/gh/JesusFilm/core/pull/3666/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `87.87% <ø> (?)` | | | [apps.api-media](https://app.codecov.io/gh/JesusFilm/core/pull/3666/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | | [apps.journeys](https://app.codecov.io/gh/JesusFilm/core/pull/3666/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `41.28% <0.00%> (?)` | | | [apps.journeys-admin](https://app.codecov.io/gh/JesusFilm/core/pull/3666/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `70.70% <0.00%> (?)` | | | [apps.watch](https://app.codecov.io/gh/JesusFilm/core/pull/3666/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `59.66% <ø> (?)` | | | [libs.journeys.ui](https://app.codecov.io/gh/JesusFilm/core/pull/3666/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `74.61% <0.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 day ago

The latest updates on your projects.

Name Status Preview Updated (UTC)
journeys ✅ Ready journeys preview Thu Oct 17 16:42:07 NZDT 2024
github-actions[bot] commented 1 day ago

The latest updates on your projects.

Name Status Preview Updated (UTC)
journeys-admin ✅ Ready journeys-admin preview Thu Oct 17 16:44:09 NZDT 2024
github-actions[bot] commented 1 day ago

The latest updates on your projects.

Name Status Preview Updated (UTC)
watch ✅ Ready watch preview Thu Oct 17 16:42:51 NZDT 2024