Open GeronimoJohn opened 1 day ago
Fails | |
---|---|
:no_entry_sign: | Please request a reviewer for this PR. |
Generated by :no_entry_sign: dangerJS against ca58dd8ea7737ebee36edb4453b0f873c4cc8bca
The latest updates on your projects.
Name | Status | Preview | Updated (UTC) |
---|---|---|---|
watch | ✅ Ready | watch preview | Thu Oct 17 17:20:47 NZDT 2024 |
The latest updates on your projects.
Name | Status | Preview | Updated (UTC) |
---|---|---|---|
journeys-admin | ✅ Ready | journeys-admin preview | Thu Oct 17 17:21:52 NZDT 2024 |
The latest updates on your projects.
Name | Status | Preview | Updated (UTC) |
---|---|---|---|
videos-admin | ✅ Ready | videos-admin preview | Thu Oct 17 17:20:57 NZDT 2024 |
The latest updates on your projects.
Name | Status | Preview | Updated (UTC) |
---|---|---|---|
arclight | ✅ Ready | arclight preview | Thu Oct 17 16:39:00 NZDT 2024 |
The latest updates on your projects.
Name | Status | Preview | Updated (UTC) |
---|---|---|---|
journeys | ✅ Ready | journeys preview | Thu Oct 17 17:21:22 NZDT 2024 |
Attention: Patch coverage is 42.59259%
with 31 lines
in your changes missing coverage. Please review.
Project coverage is 79.41%. Comparing base (
ea03adc
) to head (ca58dd8
). Report is 1 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
...rd/BackgroundMedia/Image/FocalPoint/FocalPoint.tsx | 38.00% | 30 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
Issue
Users currently face challenges uploading images with exact proportions, making background image editing difficult. To improve the user experience, we're introducing the ability for users to set a focal point for background images.
Solution
To support this enhancement, we need to add two new fields—focalTop and focalLeft—to the Image Block. These fields will allow users to specify the focal point of the background image.
The following changes are made: