JesusFilm / core

JFP DS Engineering Monorepo
https://docs.core.jesusfilm.org/
19 stars 12 forks source link

feat: add expiration to completed bullmq jobs-no-qa #3669

Closed mikeallisonJS closed 4 months ago

mikeallisonJS commented 4 months ago

Description

Issue

Our bullmq redis servers are filling with completed junk, causing the volatile lru to handle deletions.

Solution

Remove completed tasks and add expiration to failed ones

linear[bot] commented 4 months ago

ENG-1182 Add expiration to completed bullmq jobs

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.74%. Comparing base (7aee1bd) to head (8126bc3). Report is 693 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3669 +/- ## ========================================== + Coverage 93.95% 94.74% +0.79% ========================================== Files 311 261 -50 Lines 5637 5061 -576 Branches 745 669 -76 ========================================== - Hits 5296 4795 -501 + Misses 270 205 -65 + Partials 71 61 -10 ``` | [Flag](https://app.codecov.io/gh/JesusFilm/core/pull/3669/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | Coverage Δ | | |---|---|---| | [apps.api-analytics](https://app.codecov.io/gh/JesusFilm/core/pull/3669/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | | [apps.api-journeys](https://app.codecov.io/gh/JesusFilm/core/pull/3669/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `95.88% <100.00%> (+<0.01%)` | :arrow_up: | | [apps.api-languages](https://app.codecov.io/gh/JesusFilm/core/pull/3669/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | | [apps.api-media](https://app.codecov.io/gh/JesusFilm/core/pull/3669/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `91.96% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.