JesusFilm / core

JFP DS Engineering Monorepo
https://docs.core.jesusfilm.org/
19 stars 12 forks source link

fix: node action reorder #3681

Closed csiyang closed 4 months ago

csiyang commented 4 months ago

Description

Issue

graph not updating when internal handles are reorganised

Solution

Call provided hook, when internal handles change docs

linear[bot] commented 4 months ago

ENG-1188 When buttons or poll options are re-ordered the website links are not automatically re-ordered on...

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.16%. Comparing base (28bd25d) to head (c748a5c). Report is 669 commits behind head on main.

Files with missing lines Patch % Lines
.../JourneyFlow/nodes/StepBlockNode/StepBlockNode.tsx 50.00% 1 Missing :warning:

:exclamation: There is a different number of reports uploaded between BASE (28bd25d) and HEAD (c748a5c). Click for more details.

HEAD has 28 uploads less than BASE | Flag | BASE (28bd25d) | HEAD (c748a5c) | |------|------|------| |apps.api-languages|7|0| |apps.api-journeys|8|0| |apps.api-media|8|0| |apps.api-analytics|5|0|
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3681 +/- ## =========================================== - Coverage 93.94% 80.16% -13.78% =========================================== Files 311 639 +328 Lines 5666 10025 +4359 Branches 748 1315 +567 =========================================== + Hits 5323 8037 +2714 - Misses 273 1834 +1561 - Partials 70 154 +84 ``` | [Flag](https://app.codecov.io/gh/JesusFilm/core/pull/3681/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | Coverage Δ | | |---|---|---| | [apps.api-analytics](https://app.codecov.io/gh/JesusFilm/core/pull/3681/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | | [apps.api-journeys](https://app.codecov.io/gh/JesusFilm/core/pull/3681/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | | [apps.api-languages](https://app.codecov.io/gh/JesusFilm/core/pull/3681/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | | [apps.api-media](https://app.codecov.io/gh/JesusFilm/core/pull/3681/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | | [apps.journeys-admin](https://app.codecov.io/gh/JesusFilm/core/pull/3681/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `80.16% <50.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 4 months ago

The latest updates on your projects.

Name Status Preview Updated (UTC)
journeys-admin ✅ Ready journeys-admin preview Fri Oct 18 09:25:06 NZDT 2024