search

JesusFreke / smali

smali/baksmali
6.29k stars 1.07k forks source link

Escape unicode filenames to fix incorrect mappings on some platforms #789

Closed tlundeen closed 3 years ago

tlundeen commented 3 years ago 
    //some filesystems treat different unicode characters as identical,
    //e.g. macOS treats Lo/ε (\u03b5) and Lo/ϵ (\u03f5) as the same character for filenames.
    //So escape packageElements strings to only use standard ascii
JesusFreke commented 3 years ago

Hi, thanks for the report and pull request. I actually solved this problem slightly differently in 1e655c2e547dbc3ea948acbbde6acb3547764ab5, ensuring that this type of collision is handled the same as something like a collision due to case insensitivity.

tlundeen commented 3 years ago

Thanks!

On Feb 16, 2021, at 4:55 PM, Ben Gruver notifications@github.com wrote:

Hi, thanks for the report and pull request. I actually solved this problem slightly differently in 1e655c2 https://github.com/JesusFreke/smali/commit/1e655c2e547dbc3ea948acbbde6acb3547764ab5, ensuring that this type of collision is handled the same as something like a collision due to case insensitivity.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/JesusFreke/smali/pull/789#issuecomment-780217462, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARAJL5YXOKZIQTFAYXY4MTS7MHZLANCNFSM4SQ6XIPQ.