search

JesusFreke / smali

smali/baksmali
6.29k stars 1.07k forks source link

fix DexWriter for hiddenapi section #816

Closed robertsmd closed 2 years ago

robertsmd commented 3 years ago

solves #815

robertsmd commented 3 years ago

successfully pushed refactors based on @Lanchon 's suggestions. Apologies for the bad casts and whatnot, java isn't my main language so I was attempting the functionality to work on a first pass and didn't cleanup.

koxu1996 commented 3 years ago

@JesusFreke Will it be merged?

SolidHal commented 3 years ago

+1 to getting this merged, confirmed this fixes the issue

dukejob commented 2 years ago

@JesusFreke This pr is really helpful

thanhpv15 commented 2 years ago

Please review this PR, it's important for Apktool's issue, @JesusFreke

JesusFreke commented 2 years ago

Thanks. Squashed and merged as 3436508beafbbacf3aae5543cdd1f1eb5edf5017